-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e libc complaints #3851
Merged
Merged
Fix e2e libc complaints #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
June 14, 2023 23:02
3 tasks
crodriguezvega
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DimitrisJim. ❤️🔥 And sorry for all the headache this caused you. 🤒
charleenfei
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for figuring this one out <3
…should match the one by github runners.
DimitrisJim
force-pushed
the
attempt_libc_mismatch
branch
from
June 15, 2023 09:15
4bff758
to
ed108e6
Compare
Thank you @DimitrisJim! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Never has a change so tiny caused such a headache. Bumping go to use
golang:1.20
apparently causedsimd
to be compiled with a dependency onlibc
that had to be>= 2.32
, hence the error logs for all e2e runs. Pretty sure the PR for bumping this didn't blow up because it was from a forked repo (running e2e from forks works okay since simd is built from the workflow and uses ubuntu 22.04 itself)Bumping the Dockerfile image to 22.04 solves the issue since it seems it comes with a newer version of libc. Alternatively, I'm sure an
apt-get
would also do the trick.Note, might be worth it to check that the simd binary is runnable after being built in the dockerfile.
closes: #XXXX
Commit Message / Changelog Entry
chore: bump image used for simd to 22.04
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.