Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade api and core #3880

Closed
wants to merge 1 commit into from
Closed

upgrade api and core #3880

wants to merge 1 commit into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 17, 2023

ref:

It seems like upgraded API also needs upgraded core. But this still fails some tests like this:

ok  	github.com/cosmos/ibc-go/v7/testing/simapp	0.583s
Error: Failed to read genesis doc from file: error reading GenesisDoc at /Users/faddat/.simapp/config/genesis.json: invalid 64-bit integer encoding "1", expected string
Usage:
  simd init [moniker] [flags]

Flags:
      --chain-id string        genesis file chain-id, if left blank will be randomly created
      --default-denom string   genesis file default denomination, if left blank default value is 'stake'
  -h, --help                   help for init
      --home string            node's home directory (default "/Users/faddat/.simapp")
      --initial-height int     specify the initial block height at genesis (default 1)
  -o, --overwrite              overwrite the genesis.json file
      --recover                provide seed phrase to recover existing key instead of creating

Global Flags:
      --log_format string   The logging format (json|plain) (default "plain")
      --log_level string    The logging level (trace|debug|info|warn|error|fatal|panic) (default "info")
      --trace               print out full stack trace on errors

--- FAIL: TestInitCmd (0.01s)
    cmd_test.go:23:
        	Error Trace:	/Users/faddat/ibc-go/testing/simapp/simd/cmd/cmd_test.go:23
        	Error:      	Received unexpected error:
        	            	error reading GenesisDoc at /Users/faddat/.simapp/config/genesis.json: invalid 64-bit integer encoding "1", expected string
        	            	Failed to read genesis doc from file
        	            	github.com/cosmos/cosmos-sdk/x/genutil/client/cli.InitCmd.func1
        	            		/Users/faddat/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/genutil/client/cli/init.go:150
        	            	github.com/spf13/cobra.(*Command).execute
        	            		/Users/faddat/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:940
        	            	github.com/spf13/cobra.(*Command).ExecuteC
        	            		/Users/faddat/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068
        	            	github.com/spf13/cobra.(*Command).Execute
        	            		/Users/faddat/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992
        	            	github.com/spf13/cobra.(*Command).ExecuteContext
        	            		/Users/faddat/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:985
        	            	github.com/cosmos/cosmos-sdk/server/cmd.Execute
        	            		/Users/faddat/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/server/cmd/execute.go:32
        	            	github.com/cosmos/ibc-go/v7/testing/simapp/simd/cmd_test.TestInitCmd
        	            		/Users/faddat/ibc-go/testing/simapp/simd/cmd/cmd_test.go:23
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1576
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_arm64.s:1172
        	Test:       	TestInitCmd
FAIL
FAIL	github.com/cosmos/ibc-go/v7/testing/simapp/simd/cmd	0.609s
FAIL

but I think these errors may be resolved by:

@faddat
Copy link
Contributor Author

faddat commented Jun 17, 2023

tentative conclusion:

we should close this and

@faddat
Copy link
Contributor Author

faddat commented Jun 21, 2023

Nobody has responded here, and really my investigation found that bumping these at least when we are using 47 is kind of a lost cause, so I'm going to close this one now.

@faddat faddat closed this Jun 21, 2023
@damiannolan
Copy link
Member

Thanks @faddat, apologies on the late response, but yes, definitely agree - I figured this was possibly going to be the case after looking at some of the dependabot bumps on this. Thanks for looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants