linting: use gci to sort imports #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
AdityaSripal,
charleenfei,
colin-axner,
damiannolan,
crodriguezvega,
chatton and
DimitrisJim
as code owners
9 tasks
faddat
force-pushed
the
faddat/second-gci
branch
from
158fc09 to
5b67512
Compare
faddat
force-pushed
the
faddat/second-gci
branch
from
5b67512 to
12da89b
Compare
charleenfei
added
the
type: code hygiene
|
Note: I could refactor this in the same manner that I did the sdk, if desired: |
crodriguezvega
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
I have to admit I haven't checked every single file, but I trust the linter to do its job. :)
Thank you, @faddat. It's nice to finally have a linter to end all import grouping/ordering wars. :D
I updated the Go style guide to recommend readers to run make lint-fix.
I am personally not strongly opinionated: to me this grouping works fine. If others think some tweaking is needed, I will be also fine with it. |
crodriguezvega
changed the title
|
I'm good with either, as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR only adds gci to ibc-go, so that we can sort imports with ease.
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.