Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(callbacks): remove reconstructed packet logic from 'SendPacket' #4343

Merged
merged 8 commits into from
Aug 14, 2023
Merged

imp(callbacks): remove reconstructed packet logic from 'SendPacket' #4343

merged 8 commits into from
Aug 14, 2023

Commits on Aug 14, 2023

  1. style: ran golangci-lint

    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    605f47c View commit details
    Browse the repository at this point in the history

  2. imp(callbacks): removed unused packet param from processCallback

    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    08747c8 View commit details
    Browse the repository at this point in the history

  3. imp(callbacks): removed packet from event functions

    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    1070a91 View commit details
    Browse the repository at this point in the history

  4. imp(callbacks): removed packet from callbackDataGetter functions

    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6210a9f View commit details
    Browse the repository at this point in the history

  5. style(callbacks): reorder func arguments for more consistency

    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    bd5896d View commit details
    Browse the repository at this point in the history

  6. imp(callbacks_test): using ibcmock.PortID for testing instead of empt… 

    …y string
    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ed295fb View commit details
    Browse the repository at this point in the history

  7. style(callbacks): renamed packetData to data in 'GetCallbackData' fun… 

    …ctions
    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ddac027 View commit details
    Browse the repository at this point in the history

  8. fix(callbacks): reordered EmitCallbackEvents parameters during usage

    @srdtrk
    srdtrk committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ae81073 View commit details
    Browse the repository at this point in the history