-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate SimApp into callbacks directory (backport #4337) #4461
Duplicate SimApp into callbacks directory (backport #4337) #4461
Conversation
(cherry picked from commit 6610409) # Conflicts: # modules/apps/callbacks/fee_transfer_test.go # modules/apps/callbacks/ica_test.go
func OverrideSendMsgWithAssertion(chain *ibctesting.TestChain, expPass bool) { | ||
// overrideSendMsg overrides both chains' SendMsgs function to a version that doesn't require | ||
// that the transaction is successful. | ||
func overrideSendMsg(chain *ibctesting.TestChain) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because v7.3's SendMsg
requires the tx to be successful, so we override it. (chain.go is not one of the copied files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was not copied in the original PR. I copied it and removed all the functions except SignAndDeliver
so that it can be used in overrideSendMsg
function
@@ -165,12 +163,7 @@ func (s *CallbacksTestSuite) ExecuteTransfer(memo string, expSendFailure bool) { | |||
clienttypes.NewHeight(1, 100), 0, memo, | |||
) | |||
|
|||
if expSendFailure { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Override has made these expSendFailure variables obsolete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe worth mentioning that the argument list of SignAndDeliver
has been modified when copying the function over from main
, right?
LGTM @srdtrk 👍 |
This is an automatic backport of pull request #4337 done by Mergify.
Cherry-pick of 6610409 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com