Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop step installing tparse in test.yml #5191

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Nov 28, 2023

Description

appears to be a relic from when this was used in Makefile, don't believe it is currently used anywhere (we'll see if CI complains)

closes: #XXXX

Commit Message / Changelog Entry

chore: remove step installing tparse in test.yml

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Nov 28, 2023
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, any idea what this was doing before?

@DimitrisJim
Copy link
Contributor Author

any idea what this was doing before?

maybe at some point some workflow executed go test and piped the results to tparse (see Makefile example of this).

Apart from that stab in the dark, no clue 🙃

@DimitrisJim DimitrisJim merged commit 9f0002f into main Nov 28, 2023
58 checks passed
@DimitrisJim DimitrisJim deleted the jim/remove-tparse-installation-step branch November 28, 2023 19:44
damiannolan pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants