fix: remove 08-wasm from 02-client exported #5306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
damiannolan,
charleenfei,
chatton,
DimitrisJim and
srdtrk
as code owners
crodriguezvega
commented
Dec 4, 2023
DimitrisJim
approved these changes
Dec 5, 2023
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
damiannolan
reviewed
Dec 5, 2023
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
damiannolan
approved these changes
Dec 5, 2023
crodriguezvega
deleted the
carlos/remove-08-wasm-from-02-client-exported
branch
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
* fix: remove 08-wasm from 02-client exported * fix grandpa test * add function to add 08-wasm to allowed clients * e2e: add gov proposal to add 08-wasm client to list of allowed clients * use cosmos chain when querying gov module address * make functions for querying allowed clients and to add 08-wasm * Update modules/light-clients/08-wasm/types/validation.go Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Update modules/light-clients/08-wasm/types/keys.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update keys.go --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit e3ab9be) # Conflicts: # e2e/tests/wasm/grandpa_test.go # modules/core/02-client/types/params.go # modules/light-clients/08-wasm/types/client_message_test.go # modules/light-clients/08-wasm/types/consensus_state_test.go # modules/light-clients/08-wasm/types/keys.go # modules/light-clients/08-wasm/types/validation.go # modules/light-clients/08-wasm/types/validation_test.go
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
* fix: remove 08-wasm from 02-client exported * fix grandpa test * add function to add 08-wasm to allowed clients * e2e: add gov proposal to add 08-wasm client to list of allowed clients * use cosmos chain when querying gov module address * make functions for querying allowed clients and to add 08-wasm * Update modules/light-clients/08-wasm/types/validation.go Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Update modules/light-clients/08-wasm/types/keys.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update keys.go --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit e3ab9be) # Conflicts: # e2e/tests/wasm/grandpa_test.go
crodriguezvega
added a commit
that referenced
this pull request
Dec 5, 2023
* fix: remove 08-wasm from 02-client exported (#5306) * fix: remove 08-wasm from 02-client exported * fix grandpa test * add function to add 08-wasm to allowed clients * e2e: add gov proposal to add 08-wasm client to list of allowed clients * use cosmos chain when querying gov module address * make functions for querying allowed clients and to add 08-wasm * Update modules/light-clients/08-wasm/types/validation.go Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Update modules/light-clients/08-wasm/types/keys.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update keys.go --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit e3ab9be) # Conflicts: # e2e/tests/wasm/grandpa_test.go # modules/core/02-client/types/params.go # modules/light-clients/08-wasm/types/client_message_test.go # modules/light-clients/08-wasm/types/consensus_state_test.go # modules/light-clients/08-wasm/types/keys.go # modules/light-clients/08-wasm/types/validation.go # modules/light-clients/08-wasm/types/validation_test.go * fix conflicts * delete e2e --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
crodriguezvega
added a commit
that referenced
this pull request
Dec 5, 2023
* fix: remove 08-wasm from 02-client exported (#5306) * fix: remove 08-wasm from 02-client exported * fix grandpa test * add function to add 08-wasm to allowed clients * e2e: add gov proposal to add 08-wasm client to list of allowed clients * use cosmos chain when querying gov module address * make functions for querying allowed clients and to add 08-wasm * Update modules/light-clients/08-wasm/types/validation.go Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Update modules/light-clients/08-wasm/types/keys.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update keys.go --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit e3ab9be) # Conflicts: # e2e/tests/wasm/grandpa_test.go * delete e2e --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
damiannolan
added a commit
that referenced
this pull request
Dec 5, 2023
* fix: remove 08-wasm from 02-client exported * fix grandpa test * add function to add 08-wasm to allowed clients * e2e: add gov proposal to add 08-wasm client to list of allowed clients * use cosmos chain when querying gov module address * make functions for querying allowed clients and to add 08-wasm * Update modules/light-clients/08-wasm/types/validation.go Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Update modules/light-clients/08-wasm/types/keys.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * Update keys.go --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.