Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(08-wasm): querier plugins implemented (backport #5345) #5381

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2023

This is an automatic backport of pull request #5345 done by Mergify.
Cherry-pick of e2bcb77 has failed:

On branch mergify/bp/08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.5.x/pr-5345
Your branch is up to date with 'origin/08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.5.x'.

You are currently cherry-picking commit e2bcb775.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/light-clients/08-wasm/internal/ibcwasm/expected_interfaces.go
	deleted:    modules/light-clients/08-wasm/internal/ibcwasm/querier.go
	new file:   modules/light-clients/08-wasm/keeper/options.go
	new file:   modules/light-clients/08-wasm/keeper/options_test.go
	modified:   modules/light-clients/08-wasm/types/events.go
	new file:   modules/light-clients/08-wasm/types/querier.go
	modified:   modules/light-clients/08-wasm/types/vm.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   modules/light-clients/08-wasm/internal/ibcwasm/wasm.go
	both modified:   modules/light-clients/08-wasm/keeper/keeper.go
	both modified:   modules/light-clients/08-wasm/keeper/keeper_test.go
	deleted by us:   modules/light-clients/08-wasm/keeper/migrations.go
	both modified:   modules/light-clients/08-wasm/testing/simapp/app.go
	both modified:   modules/light-clients/08-wasm/types/querier_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* imp: moved gas to internal

* fix: fixed compiler complaints

* feat: added 'QueryRouter' interface

* imp: passing the queryRouter to keeper

* Revert "fix: fixed compiler complaints"

This reverts commit 208e314.

* Revert "imp: moved gas to internal"

This reverts commit b45b605.

* fix(test): fixed keeper_test.go

* imp: initial querier template

* imp: moved querier to types

* fix: compiler complaints

* imp: removed querier from keeper

* feat: including default querier

* imp: added options

* feat: querier implemented fully

* docs: improved godocs

* imp: improved the querier

* style: improved styling of querier

* fix: fixed options

* fix: fixed options not being passed with config

* style: renamed variables

* imp: added review items

* imp: review items

* imp: set and get query plugins made private

* docs: added more godocs

* fix: default plugin not set

* imp: review items

* docs: added a godoc

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit e2bcb77)

# Conflicts:
#	modules/light-clients/08-wasm/internal/ibcwasm/wasm.go
#	modules/light-clients/08-wasm/keeper/keeper.go
#	modules/light-clients/08-wasm/keeper/keeper_test.go
#	modules/light-clients/08-wasm/keeper/migrations.go
#	modules/light-clients/08-wasm/testing/simapp/app.go
#	modules/light-clients/08-wasm/types/querier_test.go
@DimitrisJim DimitrisJim removed their assignment Dec 12, 2023
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ thank you @DimitrisJim!!!

@colin-axner colin-axner merged commit 4f22957 into 08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.5.x Dec 12, 2023
17 checks passed
@colin-axner colin-axner deleted the mergify/bp/08-wasm/release/v0.1.x+ibc-go-v7.3.x-wasmvm-v1.5.x/pr-5345 branch December 12, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants