Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ica): allow unordered ica channels #5633

Merged
merged 21 commits into from
Jan 17, 2024

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    fcf830f View commit details
    Browse the repository at this point in the history
  2. imp: remove the channel type = ordered checks from both host and cont…

    …roller (#5578)
    
    * rm checks and tests, amend docustring
    
    * rm unnecessary test
    charleenfei committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    3dedb40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f83cf6 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    78415d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    3f52533 View commit details
    Browse the repository at this point in the history
  2. Allow specifying order when registering ICA account (#5608)

    * proto: Add Order to MsgRegisterInterchainAccount.
    
    * chore: apply proto changes to go files.
    
    * Add ordering to cli tx for Register.
    
    * Add documentation line for tx now accepting ordering.
    
    * Address feedback review.
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    
    * Address Cian's feedback; spacing.
    
    ---------
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    DimitrisJim and crodriguezvega committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1480dca View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b73cc4 View commit details
    Browse the repository at this point in the history
  4. imp(ica/host): removed previous version validation check (#5613)

    * imp: removed validation check
    
    * test: updated icahost test
    
    * docs: added godocs
    
    * docs: added godocs
    srdtrk committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3dab69a View commit details
    Browse the repository at this point in the history
  5. chore(ica/host): require active channel be CLOSED before re-opening (#…

    …5630)
    
    * chore(ica/host): require active channel be CLOSED before re-opening
    
    * Update modules/apps/27-interchain-accounts/host/keeper/handshake_test.go
    
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    
    ---------
    
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    damiannolan and DimitrisJim committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8841699 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f23ba98 View commit details
    Browse the repository at this point in the history
  7. E2E test where unordered channel is used with ICA (#5566)

    * test: add test to use an unordered ICA channel
    
    * chore: add hard coded UNORDERED channel Order
    
    * proto: Add Order to MsgRegisterInterchainAccount.
    
    * chore: apply proto changes to go files.
    
    * chore: apply proto changes to go files.
    
    * chore: e2e test passing with hard coded ordered value
    
    * Add ordering to cli tx for Register.
    
    * Add documentation line for tx now accepting ordering.
    
    * Address feedback review.
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    
    * Address Cian's feedback; spacing.
    
    * Update e2e/tests/interchain_accounts/base_test.go
    
    Co-authored-by: Charly <charly@interchain.io>
    
    ---------
    
    Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    Co-authored-by: Charly <charly@interchain.io>
    4 people committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e059759 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    8164401 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7499677 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91d3e25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2e1812 View commit details
    Browse the repository at this point in the history
  5. chore: doc lint issue fix

    DimitrisJim committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b55ab11 View commit details
    Browse the repository at this point in the history
  6. docs: add extra information about ICA channel reopening (#5631)

    * docs: add extra information about ICA channel reopening
    
    * add link to active channels section
    
    * Apply suggestions from code review
    
    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
    
    * Update 01-overview.md
    
    ---------
    
    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
    3 people committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8b3792a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8a69659 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4523a74 View commit details
    Browse the repository at this point in the history
  9. chore: lintertroubles

    DimitrisJim committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    15b279d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f52b1d4 View commit details
    Browse the repository at this point in the history