-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: remove event emission on channel upgrade #6063
Merged
crodriguezvega
merged 20 commits into
cosmos:main
from
hoangdv2429:chore/trim_event_emissions
Apr 9, 2024
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
26fc764
remove event emission
hoangdv2429 8aa4e02
Merge branch 'main' into chore/trim_event_emissions
hoangdv2429 b5840a0
Update events.go
hoangdv2429 ced7b32
update test acrroding
hoangdv2429 b7949a6
Merge branch 'main' into chore/trim_event_emissions
hoangdv2429 9294811
Merge branch 'main' into chore/trim_event_emissions
hoangdv2429 51964dd
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega 1449925
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega e590747
Merge branch 'main' into chore/trim_event_emissions
hoangdv2429 e2d4583
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega d5989d9
Merge branch 'main' into chore/trim_event_emissions
charleenfei 2dbfd46
update hermes tag
crodriguezvega c481fce
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega 0efb797
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega 77546f8
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega 1834387
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega c7b17f0
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega b0ad66c
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega 31edbd0
Merge branch 'main' into chore/trim_event_emissions
hoangdv2429 639362f
Merge branch 'main' into chore/trim_event_emissions
crodriguezvega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we been using this tag for the last few months?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were using
luca_joss-...
, but when these attributes were removed, Luca discovered while debugging that there was a bug in hermes and fixed it in this new tag.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more context, the branch
sean-channel-upgradability
was the branch for the channel upgrade beta implementation and theluca_joss-channel-upgrade-authority
was the branch adding the changes that came after the beta (e.g. initiating an upgrade only with authority). Between the release of channel upgrade and now the branchluca_joss-channel-upgrade-authority
has been merged insean-channel-upgradability
so that we only have one open PR related to channel upgrade. New Hermes Docker images for channel upgrade, until it is merged, will be in the tag sean-channel-upgradability.