-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of globals from 08-wasm #6103
Commits on Apr 3, 2024
-
Move functionality from client state methods to light client module m…
…ethods. - Yank all statements and delete functions as needed. - Make any required functions from types/ public. - Add the vm in the 08-wasm keeper. - Update documentation to include documentation of deleted functions.
Configuration menu - View commit details
-
Copy full SHA for 6dc7fa9 - Browse repository at this point
Copy the full SHA 6dc7fa9View commit details -
Remove global VM, introspection to retrieve client identifier.
- Refactor signatures to explicitly pass vm, client identifier for time being. - Refactor tests to conform with new signatures. - Replace occurences of `ibcwasm.GetVM` in other keeper functions.
Configuration menu - View commit details
-
Copy full SHA for 8ec8bf6 - Browse repository at this point
Copy the full SHA 8ec8bf6View commit details
Commits on Apr 4, 2024
-
Move migrateContract from clientState to keeper method.
- Matches moves for other functions. - Move is required to address future circular dependency for state management (keeper would import types and types would import keeper) - Rm migrate_contract(test).go files.
Configuration menu - View commit details
-
Copy full SHA for c3ddc51 - Browse repository at this point
Copy the full SHA c3ddc51View commit details -
Move state management to keeper.
- Remove globals for state (Checksums) - Move access functions from types to keeper, move tests. - Update calls using global to instead go through keeper.
Configuration menu - View commit details
-
Copy full SHA for 6e9d4a6 - Browse repository at this point
Copy the full SHA 6e9d4a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cc45a4 - Browse repository at this point
Copy the full SHA 5cc45a4View commit details -
Remove pending todo in test for migrate contract.
This previously was testing a function that didn't set the client state after calling the contract (invoking through the keeper always sets a client state after contract invocation). Hence, even if we don't set explicitly in the migrateFn callback, we _still_ get a client state in the end.
Configuration menu - View commit details
-
Copy full SHA for 139c806 - Browse repository at this point
Copy the full SHA 139c806View commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f3a7aae - Browse repository at this point
Copy the full SHA f3a7aaeView commit details
Commits on Apr 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6f5616a - Browse repository at this point
Copy the full SHA 6f5616aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7373de0 - Browse repository at this point
Copy the full SHA 7373de0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1692f8b - Browse repository at this point
Copy the full SHA 1692f8bView commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5127126 - Browse repository at this point
Copy the full SHA 5127126View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57c2235 - Browse repository at this point
Copy the full SHA 57c2235View commit details -
refactor: remove queryRouter global variable
- Move into the func for creating new plugins, pass it to acceptStargateQuery directly. This is probably what wasmd did (see they don't accept a query router now?). Since we don't use the get elsewhere, this was the smallest diff for a globa. - Preemptively ran make lint-fix, gotcha linting crybaby.
Configuration menu - View commit details
-
Copy full SHA for 12c34cb - Browse repository at this point
Copy the full SHA 12c34cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 151a546 - Browse repository at this point
Copy the full SHA 151a546View commit details -
Configuration menu - View commit details
-
Copy full SHA for f679ccf - Browse repository at this point
Copy the full SHA f679ccfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e726ce9 - Browse repository at this point
Copy the full SHA e726ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 480fcf8 - Browse repository at this point
Copy the full SHA 480fcf8View commit details -
Make migrateContractCode a private function, clean up uneeded export …
…in export_test.go for types/.
Configuration menu - View commit details
-
Copy full SHA for d614a93 - Browse repository at this point
Copy the full SHA d614a93View commit details -
refactor: Move vm entrypoints to keeper.
- Remove generic types and do unmarshalling in light client methods. - Move all functions onto keeper and adjust call sites.
Configuration menu - View commit details
-
Copy full SHA for 8e6b567 - Browse repository at this point
Copy the full SHA 8e6b567View commit details -
chore: address some testing todos. Move testing unmarshal failure cas…
…e to light client tests.
Configuration menu - View commit details
-
Copy full SHA for 2aea36f - Browse repository at this point
Copy the full SHA 2aea36fView commit details -
- Consistently use wasmClientKeeper as local var name. - Reorg keeper fields slightly. - Rm 'vm.go' which was already empty.
Configuration menu - View commit details
-
Copy full SHA for 23decca - Browse repository at this point
Copy the full SHA 23deccaView commit details
Commits on Apr 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f23bc7c - Browse repository at this point
Copy the full SHA f23bc7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2836073 - Browse repository at this point
Copy the full SHA 2836073View commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 76d8055 - Browse repository at this point
Copy the full SHA 76d8055View commit details