-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: simplify types_tests setup to remove uneeded setting up of a mock vm #6164
Conversation
WalkthroughThe changes involve significant modifications in the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -373,21 +384,15 @@ func (suite *TypesTestSuite) TestNewMigrateClientWrappedStore() { | |||
} | |||
} | |||
|
|||
// GetSubjectAndSubstituteStore returns a subject and substitute store for testing. | |||
// GetSubjectAndSubstituteStore returns two dummy KVStores for testing the migrate client wrapping store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the stores don't necessarily need to be actual ones after client creation; we can just create two dummy ones. This change also makes the move of this type to internal
easier (probably, haven't made the move yet to see if something will bite me in the ass 😆)
I think I don't even need to create a chain in the suite here in theory, right? Should be able to create some empty kv stores directly, I'd assume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again @DimitrisJim, just left a suggestion on building prefix stores
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Quality Gate passed for 'ibc-go'Issues Measures |
Description
follow up to #6103, types testing doesn't require a mock VM, can trim down testing code.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.Summary by CodeRabbit