Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: allow memo strings instead of keys for transfer authorizations (backport #6268) #6288

Merged
merged 6 commits into from
May 13, 2024

Commits on May 10, 2024

  1. imp: allow memo strings instead of keys for transfer authorizations (#…

    …6268)
    
    * imp: allow memo strings instead of keys for transfer authorizations
    
    * add changelog
    
    * handle error from compact
    
    * return error
    
    * improve test
    
    * not enforce that memo strings of allowed packet data must be JSON-encoded strings
    
    * use slices contains to check if memo is allowed
    
    * Update modules/apps/transfer/types/transfer_authorization.go
    
    Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
    
    * Update modules/apps/transfer/types/transfer_authorization.go
    
    Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
    
    * lint
    
    ---------
    
    Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
    (cherry picked from commit 0a22b7a)
    
    # Conflicts:
    #	docs/docs/02-apps/01-transfer/08-authorizations.md
    #	modules/apps/transfer/types/authz.pb.go
    #	modules/apps/transfer/types/keys.go
    #	modules/apps/transfer/types/transfer_authorization.go
    #	modules/apps/transfer/types/transfer_authorization_test.go
    #	proto/ibc/applications/transfer/v1/authz.proto
    crodriguezvega authored and mergify[bot] committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e1b16cc View commit details
    Browse the repository at this point in the history
  2. fix conflicts

    crodriguezvega committed May 10, 2024
    Configuration menu
    Copy the full SHA
    43c9261 View commit details
    Browse the repository at this point in the history
  3. don't use slices

    crodriguezvega committed May 10, 2024
    Configuration menu
    Copy the full SHA
    789aff3 View commit details
    Browse the repository at this point in the history
  4. use sdkerrors

    crodriguezvega committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6ab8282 View commit details
    Browse the repository at this point in the history
  5. remove docs

    crodriguezvega committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f5cecec View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    ff161c5 View commit details
    Browse the repository at this point in the history