feat(transfer): use protobuf for packet data v2 serialisation #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
srdtrk and
chatton
as code owners
DimitrisJim
commented
Jul 2, 2024
DimitrisJim
force-pushed
the
jim/6630-protobuf-for-packet-data
branch
from
b4c6a5e
to
a4a763a
Compare
colin-axner
reviewed
Jul 3, 2024
| "failure: new field present in packet data", | ||
| func() { | ||
| // packet data containing extra field unknown to current proto file. | ||
| packetDataBz = []byte("\n%\n\x1d\n\x04atom\x1a\x15\n\btransfer\x12\tchannel-0\x12\x041000\x12\x06sender\x1a\breceiver*\x002\tnew_value") |
There was a problem hiding this comment.
could be nice to take packetDataBz and append the new field for readability
There was a problem hiding this comment.
ah, right, I'll do that before merge!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6630
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.