add cli to get denom hash from trace path and base denom

[nir1218]

Description

Add a command to the CLI to get a denom hash from a trace path based on issue number 497.
#497
I may need help with some of the items i need to check off below, especially regarding documentation, since this is my first time submitting a PR.
closes: #497

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[crodriguezvega]

Thanks for submitting this so quick! I think it's looking good!

[codecov-commenter]

Codecov Report

Merging #679 (135650e) into main (087bc5d) will increase coverage by 0.01%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   79.62%   79.63%   +0.01%     
==========================================
  Files         145      145              
  Lines       10656    10676      +20     
==========================================
+ Hits         8485     8502      +17     
- Misses       1755     1757       +2     
- Partials      416      417       +1     

Impacted Files	Coverage Δ
modules/apps/transfer/keeper/grpc_query.go	78.26% <85.00%> (+2.75%)	⬆️

[colin-axner]

Woo! Thanks for the contribution! I agree with @crodriguezvega requests. Great work so far!

[colin-axner]

Ideally the success case doesn't have to perform any functionality. This allows you to be certain the failing cases would normally succeed except in the scenario specified.

I would set the req to a default before calling tc.malleate in the for loop, I'd also set the denom trace in state. Then the case "not found denom trace" would delete the denom trace in state (or set it to a different trace that doesn't exist in state)

[nir1218]

@colin-axner @codecov-commenter I need further clarification on this point. I mistakenly put the request block before and after setting the state. If I removed the duplicate before setting the state would that be good; there is no significant difference between the test method I wrote and the one for GetDemonTrace.

[colin-axner]

Checkout the suggestion I put below. Don't commit that with the github UX because the formatting is probably wrong. But the main difference is adding:

                       req = &types.QueryDenomHashRequest{
					Trace: reqTrace.GetFullDenomPath(),
			}
			suite.chainA.GetSimApp().TransferKeeper.SetDenomTrace(suite.chainA.GetContext(), reqTrace)

in the for loop before tc.malleate()

[crodriguezvega]

@nir1218, can you also please add an entry in the CHANGELOG.md under the Features section?

[nir1218]

@crodriguezvega I have added an entry in the CHANGELOG.md under the Features section

[crodriguezvega]

Fantastic work. Thank you so much for this! 👏
From my side I think it looks good, pending on the comment by @colin-axner about the tests.

[nir1218]

@crodriguezvega What is the next step for this PR to be merged?

[crodriguezvega]

@crodriguezvega What is the next step for this PR to be merged?

I think it's good to go now. Let me double check with @colin-axner tomorrow and if everything is fine in his opinion, then we'll merge it.