Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(state!): check upgrade compatibility in channel upgrade confirm #6935

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix(state!): check upgrade compatibility in channel upgrade confirm #6935

merged 1 commit into from
Jul 25, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

Changes for cosmos/ibc#1127.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

AdityaSripal
AdityaSripal approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crodriguezvega !!

@crodriguezvega crodriguezvega added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 3a192be Jul 25, 2024
70 of 71 checks passed
@crodriguezvega crodriguezvega deleted the carlos/check-upgrade-compatibility-confirm branch July 25, 2024 07:51
mergify bot pushed a commit that referenced this pull request Jul 25, 2024
@crodriguezvega @mergify
fix(state!): check upgrade compatibility in channel upgrade confirm (#…
c24b630 
…6935)

(cherry picked from commit 3a192be)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Jul 25, 2024
@crodriguezvega @mergify
fix(state!): check upgrade compatibility in channel upgrade confirm (#…
6c8fc36 
…6935)

(cherry picked from commit 3a192be)
This was referenced Jul 25, 2024
Merged
Merged
crodriguezvega added a commit that referenced this pull request Jul 26, 2024
@mergify @crodriguezvega
fix(state!): check upgrade compatibility in channel upgrade confirm (…
cdaaa94 
…backport #6935) (#6944)

* fix(state!): check upgrade compatibility in channel upgrade confirm (#6935)

(cherry picked from commit 3a192be)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
@crodriguezvega crodriguezvega mentioned this pull request Jul 26, 2024
Merged
10 tasks
crodriguezvega added a commit that referenced this pull request Jul 27, 2024
@mergify @crodriguezvega @DimitrisJim
fix(state!): check upgrade compatibility in channel upgrade confirm (#…
f08a319 
…6935) (#6945)

(cherry picked from commit 3a192be)

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@sangier sangier sangier approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim DimitrisJim is a code owner

@bznein bznein Awaiting requested review from bznein bznein is a code owner

Assignees
No one assigned
Labels
backport-to-v8.4.x backport-to-v9.0.x priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crodriguezvega @gjermundgaraba @damiannolan @AdityaSripal @sangier