Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Cian & Nikolas Retreat Week #7301

Closed
wants to merge 5 commits into from

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Sep 17, 2024

Description

Details can be discussed in the engineering call

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@chatton chatton changed the title [POC] Cian & Nikolas Retreat Work [POC] Cian & Nikolas Retreat Week Sep 17, 2024
@chatton chatton mentioned this pull request Sep 17, 2024
10 tasks
Copy link

sonarcloud bot commented Sep 17, 2024

@chatton
Copy link
Contributor Author

chatton commented Sep 19, 2024

This PR updates the existing eureka logic to perform a conversion on a Packet to internally use the PacketV2 commitment structure.

There is an alternate approach using a different message server were explored during the retreat week here #7302

@chatton
Copy link
Contributor Author

chatton commented Oct 1, 2024

Closing in favour of #7302

@chatton chatton closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant