chore: move PacketV2 to channel/v2 proto and rename it to Packet #7357
Conversation
| @@ -101,42 +101,6 @@ func commitV2Packet(packet Packet) []byte { | |||
| return hash[:] | |||
| } | |||
|
|
|||
| // CommitPacketV2 returns the V2 packet commitment bytes. The commitment consists of: | |||
There was a problem hiding this comment.
These methods are not used right now and can be reimplemented in the right place (they wouldn't compile left here now) in further PRs
There was a problem hiding this comment.
You could probably just move them to the v2/types directory in a new packet.go file. What do you think? Might be easier to keep them rather than digging into old/historical branches to find as we move forward.
These should ultimately change eventually anyways pending spec
There was a problem hiding this comment.
they would compile if moved as Damian says no? +1 on doing it now, seems like an easy move to do for time being.
There was a problem hiding this comment.
Yeah SGTM :) Will do! (I will still get rid of the conversion function that we don't need anymore at all)
bznein
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
| @@ -101,42 +101,6 @@ func commitV2Packet(packet Packet) []byte { | |||
| return hash[:] | |||
| } | |||
|
|
|||
| // CommitPacketV2 returns the V2 packet commitment bytes. The commitment consists of: | |||
There was a problem hiding this comment.
You could probably just move them to the v2/types directory in a new packet.go file. What do you think? Might be easier to keep them rather than digging into old/historical branches to find as we move forward.
These should ultimately change eventually anyways pending spec
|
Description
closes: #7347
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.