Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main to SDK release #79

Merged
merged 21 commits into from
May 6, 2021
Merged

Update main to SDK release #79

merged 21 commits into from
May 6, 2021

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Mar 9, 2021

This is a tracking branch to prepare for the next v0.43.0 release of the SDK which will contain a removed IBC module

Currently using commit on master branch: e3e89f52607b9d205e1ddea4af2d47e98e0ff2b1

@codecov-io
Copy link

Codecov Report

Merging #79 (0373147) into main (9c6edc4) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   65.22%   65.19%   -0.04%     
==========================================
  Files         127      127              
  Lines        8405     8403       -2     
==========================================
- Hits         5482     5478       -4     
- Misses       2557     2558       +1     
- Partials      366      367       +1     
Impacted Files Coverage Δ
modules/core/02-client/types/proposal.go 81.96% <ø> (-0.58%) ⬇️
modules/core/02-client/keeper/proposal.go 91.11% <0.00%> (-4.45%) ⬇️

@colin-axner colin-axner marked this pull request as ready for review April 23, 2021 09:39
@colin-axner colin-axner marked this pull request as draft April 23, 2021 11:45
@colin-axner
Copy link
Contributor Author

colin-axner commented May 5, 2021

marking ready for review, lots of changes already in this pr so I think it'd be good to get this through a review cycle. The main branch is already on an arbitrary SDK commit, so I don't think it hurts to just move that commit much closer to what will be the next SDK release

@colin-axner colin-axner marked this pull request as ready for review May 5, 2021 13:40
@@ -179,17 +179,6 @@ func (suite *KeeperTestSuite) TestHandleUpgradeProposal() {
}
}, false,
},
{
"schedule upgrade fails - plan sets time and height", func() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade time got removed

@codecov-commenter
Copy link

Codecov Report

Merging #79 (19f72bd) into main (2c880a2) will decrease coverage by 0.66%.
The diff coverage is 87.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   79.17%   78.51%   -0.67%     
==========================================
  Files         109      109              
  Lines        6526     6524       -2     
==========================================
- Hits         5167     5122      -45     
- Misses       1004     1044      +40     
- Partials      355      358       +3     
Impacted Files Coverage Δ
modules/apps/transfer/keeper/keeper.go 83.33% <ø> (ø)
modules/apps/transfer/module.go 60.68% <ø> (+0.68%) ⬆️
modules/core/02-client/keeper/keeper.go 84.75% <ø> (ø)
modules/core/02-client/types/encoding.go 60.00% <ø> (ø)
modules/core/02-client/types/proposal.go 81.96% <ø> (-0.58%) ⬇️
modules/core/03-connection/keeper/grpc_query.go 91.57% <0.00%> (ø)
modules/core/04-channel/keeper/grpc_query.go 90.47% <0.00%> (ø)
modules/core/04-channel/types/packet.go 80.00% <ø> (ø)
modules/core/keeper/keeper.go 81.25% <ø> (ø)
modules/core/module.go 53.84% <ø> (+2.56%) ⬆️
... and 24 more

@colin-axner colin-axner enabled auto-merge (squash) May 6, 2021 10:34
@colin-axner colin-axner merged commit 1ff0da6 into main May 6, 2021
@colin-axner colin-axner deleted the colin/update-main branch May 6, 2021 10:41
faddat referenced this pull request in notional-labs/ibc-go Mar 1, 2022
add chainylira to the testnet
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
Serialization and hashing

This brings interfaces and implementations for easy hashing and
serialization of common types.

* Use sha256-simd for better performance
* Use BinaryMarshaler and BinaryUnmarshaler interface
* Use protobuf instead of gob in store
* Move Hash into separate package
* Round trip test for protobuf serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants