Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update docs for reward denom change #1489

Merged
merged 9 commits into from
Dec 15, 2023
Merged

docs: update docs for reward denom change #1489

merged 9 commits into from
Dec 15, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Dec 8, 2023 •
edited
Loading

Description

Closes: #1292

Update docs on how the reward distribution works and how to whitelist reward denoms.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)
  • Checked that the documentation website can be built and deployed successfully (run make build-docs)

@mpoke mpoke requested a review from a team as a code owner December 8, 2023 11:37
@github-actions github-actions bot added the C:Docs Assigned automatically by the PR labeler label Dec 8, 2023
@mpoke mpoke changed the title docs: update dcos for reward denom change docs: update docs for reward denom change Dec 8, 2023
p-offtermatt
p-offtermatt approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but I'll approve.
The one I most think should be addressed
is the comment about finding the ibc denom from the native denom.

docs/docs/features/proposals.md Outdated

:::tip
Besides native provider denoms (e.g., `uatom`), please use the `ibc/*` denom trace format.
For example, use `ibc/0025F8A87464A471E66B234C4F93AEC5B4DA3D42D7986451A059273426290DD5`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question: Could you explain here how to find the ibc denom of an asset on the hub? specifically what commands to run to figure it out, e.g. how you knew that untrn is ibc/...... on the hub?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw, later you explain how to get the base denom from an ibc denom. I think the other direction is also relevant, i.e. how do you find the ibc denom when you know the base denom.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 78f3c9e

docs/docs/features/reward-distribution.md Outdated Show resolved Hide resolved
docs/docs/features/reward-distribution.md Outdated Show resolved Hide resolved
docs/docs/features/reward-distribution.md Outdated Show resolved Hide resolved
docs/docs/features/proposals.md Outdated Show resolved Hide resolved
docs/docs/features/reward-distribution.md Outdated Show resolved Hide resolved
mpoke and others added 6 commits December 8, 2023 18:37
@mpoke
add example of denom-hash query
78f3c9e
@mpoke @p-offtermatt
Update docs/docs/features/reward-distribution.md
e99e0dd 
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
@mpoke @p-offtermatt
Update docs/docs/features/reward-distribution.md
5000cdf 
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
@mpoke @p-offtermatt
Update docs/docs/features/reward-distribution.md
aaffbad 
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
@mpoke @p-offtermatt
Update docs/docs/features/proposals.md
7c9d600 
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
@mpoke @p-offtermatt
Update docs/docs/features/reward-distribution.md
66be2ca 
Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
MSalopek
MSalopek approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSalopek MSalopek added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit f1a6129 Dec 15, 2023
13 checks passed
@MSalopek MSalopek deleted the marius/1292-reward-denoms branch December 15, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@p-offtermatt p-offtermatt p-offtermatt approved these changes

Assignees
No one assigned
Labels
C:Docs Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs for reward denom change
3 participants
@mpoke @MSalopek @p-offtermatt