Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query balance cmd returns duplicate responses #459

Closed
colin-axner opened this issue Mar 17, 2021 · 4 comments
Closed

query balance cmd returns duplicate responses #459

colin-axner opened this issue Mar 17, 2021 · 4 comments
Labels
good first issue Good for newcomers T: ux TYPE: Issue or Pull Request related to developer experience

Comments

@colin-axner
Copy link
Contributor

rly tx transfer ibc-0 ibc-1 1000000samoleans $(rly chains address ibc-1)
rly tx transfer ibc-2 ibc-1 1000000samoleans $(rly chains address ibc-1)
rly tx rly demo -d
rly tx rly demo2 -d

rly q bal ibc-1

// result
1000000ibc/27A6394C3F9FF9C9DCF5DFFADF9BB5FE9A37C7E92B006199894CF1824DF9AC7C,
1000000ibc/27A6394C3F9FF9C9DCF5DFFADF9BB5FE9A37C7E92B006199894CF1824DF9AC7C,
1000000ibc/C1840BD16FCFA8F421DAA0DAAB08B9C323FC7685D0D7951DC37B3F9ECB08A199,
1000000ibc/C1840BD16FCFA8F421DAA0DAAB08B9C323FC7685D0D7951DC37B3F9ECB08A199,
100000000000samoleans,100000000000samoleans,100000000000stake,100000000000stake
@colin-axner colin-axner added the T: ux TYPE: Issue or Pull Request related to developer experience label Mar 17, 2021
@colin-axner
Copy link
Contributor Author

This code is incorrect

We should be displaying the full denom trace and the default case should not add the coin to out. The code could be rewritten, we want to display the denom trace for each coin that is an IBC token. The ICS 20 query functions probably provide a better way of doing this

@colin-axner colin-axner added the good first issue Good for newcomers label Mar 17, 2021
@colin-axner
Copy link
Contributor Author

Tagging good first issue since it isn't hard to fix, but will take some time to fix if you are unfamiliar with IBC. Don't attempt to fix if you want something that takes less than 10 minutes

@colin-axner
Copy link
Contributor Author

TODO: Apply review comments

@boojamya
Copy link
Contributor

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers T: ux TYPE: Issue or Pull Request related to developer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants