Fix query balance response #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilkumarpilli
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
colin-axner
approved these changes
Mar 22, 2021
| continue | ||
| } | ||
|
|
||
| for i, d := range dts.DenomTraces { |
There was a problem hiding this comment.
I think we should just do a query using this route instead of looping over all the traces
|
|
||
| for i, d := range dts.DenomTraces { | ||
| if c.Denom == d.IBCDenom() { | ||
| out = append(out, sdk.Coin{Denom: d.GetFullDenomPath(), Amount: c.Amount}) |
There was a problem hiding this comment.
I think I'd rather make our own coin type, something like
type Coin struct {
Denom string
Amount uint64
}It is a little unnecessary, but I don't really trust things not to go wrong, since using the full denom path is an invalid sdk.Coin
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.