Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new client with custom unbonding period #1313

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

boojamya
Copy link
Contributor

This PR adds the flag --client-unbonding-period to create a new client with a specific unbonding period.

Main use case scenario:

  • client created
  • chain upgrade changes the unbonding period
  • client expires
  • substitute expired client with new client

In order to substitute a new client with the expired one, the new client must match the old client state (including the unbonding period).

Without matching the client state, you get this ibc-go error:
subject client state does not match substitute client state: invalid client state substitute

@boojamya boojamya marked this pull request as ready for review October 20, 2023 21:53
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had the one comment but otherwise this looks good, i'll just approve now so its not blocked

relayer/chains/cosmos/provider.go Outdated Show resolved Hide resolved
@boojamya boojamya enabled auto-merge (squash) November 2, 2023 23:40
@boojamya boojamya merged commit 26aa983 into main Nov 2, 2023
19 checks passed
@boojamya boojamya deleted the dan/unbonding-period branch November 2, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants