More Agoric tweaks #399
More Agoric tweaks #399
Conversation
michaelfig
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
|
This pull request introduces 1 alert when merging 6c68cfe into b1360ef - view on LGTM.com new alerts:
|
michaelfig
force-pushed
the
mfig/agoric-tweaks
branch
from
6c68cfe to
d274e1e
Compare
|
This pull request introduces 1 alert when merging d274e1e into b1360ef - view on LGTM.com new alerts:
|
| @@ -206,7 +206,15 @@ $ %s tx con demo-path -o 3s`, appName, appName, appName)), | |||
| return err | |||
| } | |||
|
|
|||
| modified, err := c[src].CreateOpenConnections(c[dst], retries, to) | |||
| // ensure that the clients exist | |||
| modified, err := c[src].CreateClients(c[dst]) | |||
There was a problem hiding this comment.
Should similar logic exist for CreateChannel? Where we create client and connection if they don't exist?
cc: @colin-axner
There was a problem hiding this comment.
Where we create client and connection if they don't exist?
Possibly. The current tx link subcommand does that already, FWIW.
There was a problem hiding this comment.
no preference here, maybe it makes sense to deprecate create channels? or rename tx link? Doesn't make too much sense to maintain 2 commands that do the same thing
There was a problem hiding this comment.
opened #400, outside the scope of this pr
michaelfig
force-pushed
the
mfig/agoric-tweaks
branch
from
d274e1e to
5b48b23
Compare
I found these changes were useful to help make the Agoric dynamic IBC layer work correctly:
rly config show --jsonto dump the YAML config as JSONrly tx connshould create the client if it isn't already%sformat argument torly tx raw sendnchainzdefault to set up the connections but not relay any paths--log_leveltowarnto help prevent noise