auto update clients to prevent expiry #412
Conversation
akhilkumarpilli
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
cmd/start.go
Outdated
| func UpdateClientsFromChains(src, dst *relayer.Chain) (sleepTime time.Duration, err error) { | ||
| var srcTimeExpiry, dstTimeExpiry time.Duration | ||
|
|
||
| thresholdTime := viper.GetDuration(flagThresholdTime) |
There was a problem hiding this comment.
This logic should not be here. We should just return timeToExpiry in this function and subtract thresholdTime from caller.
cmd/start.go
Outdated
| return 0, err | ||
| } | ||
|
|
||
| if srcTimeExpiry > 0 { |
There was a problem hiding this comment.
This can be massively simplified by just using math.Min.
If either srcTimeExpiry or dstTimeExpiry is less than 0 just return an error.
cmd/start.go
Outdated
| } | ||
|
|
||
| if srcTimeExpiry <= 0 || dstTimeExpiry <= 0 { | ||
| return 0, fmt.Errorf("one of the clients (%s,%s) trusting period is 0 or expired", |
There was a problem hiding this comment.
I think it'd be useful to separate these checks and tell the user which client on which chain is expired. Also I believe it is not possible for the trusting period to be 0
relayer/client-tx.go
Outdated
| return 0, err | ||
| } | ||
|
|
||
| dstUH, err := sh.GetTrustedHeader(dst, src) |
There was a problem hiding this comment.
I think the logic here is switched. Nonetheless this will be replaced with src.GetIBCUpdateHeader(dst) after merging my refactor pr
There was a problem hiding this comment.
just merged that pr to master, so you can update now
relayer/client-tx.go
Outdated
| // GetClientAndUpdate update clients to prevent expiry | ||
| func GetClientAndUpdate(src, dst *Chain, thresholdTime time.Duration) (time.Duration, error) { |
There was a problem hiding this comment.
this name is misleading in some way, this doesn't return the client but the trusting period.
Fixes: #395
Added a go routine in
rly startcommand, which will run in a loop for every 1m by default. It will check all the clients in provided path and if they are going to expire in next 10mins (default), it will update. Default time values for checking expiry can be modified by flags.