refactor update message construction #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
Feb 18, 2021
| @@ -166,7 +166,7 @@ func (rp *relayMsgRecvPacket) Msg(src, dst *Chain) (sdk.Msg, error) { | |||
| if rp.dstComRes == nil { | |||
| return nil, fmt.Errorf("receive packet [%s]seq{%d} has no associated proofs", src.ChainID, rp.seq) | |||
| } | |||
| version := clienttypes.ParseChainID(src.PathEnd.ChainID) | |||
| version := clienttypes.ParseChainID(src.ChainID) | |||
There was a problem hiding this comment.
The relayer always confuses me, but I don't think we verify the path end chain id often and it is unclear to me if it is the chain id of the chain the client is on or the chain id of the client itself. We should just rely on the chain id associated with the light client here
There was a problem hiding this comment.
this becomes problematic if the chain-ids are swapped in the config for path end
|
Started taking this on, but the bug report was a false alarm cleans up handshakes. I was going to fix the recv and acks part but the logic is super messy to detangle. I'd prefer to put this off until I get an actual bug report |
…actor-update-msgs
) * bump sdk version to v0.41.3 (#430) * bump sdk version * bump SDK to v0.41.3 * inital work for refactoring state based relaying * Modify relayPacketFromSequence * update tendermint client to not prune light blocks (#437) * Address comments and fix lint issues * Fix lint issues * Remove onRtyErr (lint issue) * typo fix (#438) * disable tm pruning (#441) * update release naming (#442) * Implement swagger docs and fix path validation (#434) * Add swagger setup * Add some routes docs and swagger ui * Add few more route docs * Add swagger docs for remaining routes * Fix golint issues * Fix unused lint issues * check chain-id in AddChain * add a light client database lock (#447) Add a lock to prevent multiple processes from attempting to access the light client database at the same time. This typically resulted in unnecessary errors or even panics * Close database connection even if second error triggers (#449) Co-authored-by: Mark <mjackson@microtick.com> * address comments Co-authored-by: akhilkumarpilli <akhilkumar7947@gmail.com> Co-authored-by: Afanti <fanjiahe2000@163.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: Mark | Microtick <409166+mark-microtick@users.noreply.github.com> Co-authored-by: Mark <mjackson@microtick.com>
colin-axner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #425