Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix light block not found error on missing header #453

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix light block not found error on missing header #453

merged 1 commit into from
Mar 12, 2021

Conversation

AdityaSripal
Copy link
Member

This should fix #452, though I don't know of a way to test

@colin-axner colin-axner changed the title #452 Fix Fix light block not found error on missing header Mar 12, 2021
colin-axner
colin-axner approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Great fix.

Tested an old version via dev env, deleting light cilent, then trying to transfer -> light block not found

Tested this version via dev env, deleting light client, then trying to transfer -> success

@colin-axner colin-axner merged commit a680ed8 into master Mar 12, 2021
@colin-axner colin-axner deleted the aditya/get-header branch March 12, 2021 12:23
@hacheigriega hacheigriega mentioned this pull request Mar 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add light block to trusted store when missing
2 participants
@AdityaSripal @colin-axner