Update light client if close to expiration #861
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to ensure light clients don’t expire on low trafficked paths where
MsgUpdateClient
isn’t being sent regularly.The
assembleAndSendMessages
function gets called on every block that has available signals to process. This is where we put a check to see if the light client is close to being expired.We update the light client if it has less than 1/3 of its trusting period left.
We get the trusting period of the client when we create a new
cosmos_chain_processor
and cache this info so it is not need to make this call every block.I believe all of the client state info, including the trusting period, will be updated in the relayers cache every time it handles relevant transaction messages
Question:
Todo:
Props to @agouin for taking the time to run through this with me.
Closes: #853