Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #115

Merged
merged 7 commits into from
Nov 12, 2020
Merged

Versioning #115

merged 7 commits into from
Nov 12, 2020

Conversation

lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Sep 22, 2020

Blocked by: @nassdonald's design for the version switcher.

Related: https://github.com/allinbits/design/issues/335

  • uses router push to switch version
  • user must add an array of versions to themeConfig in .vuepress/config.js in order to use version switcher
  • unable to test it locally even after using make build-docs to generate different versions in ~/output locally

For contributor use:

  • Linked to relevant Github issues
  • Provided a description
  • Added a relevant changelog
  • Re-reviewed Files changed

For admin use:

  • Checked errors / warnings on console
  • Ran npm run build in the local dev repo to make sure it compiles without any errors
  • When bumping version, made sure package-lock.json has the latest version

@lovincyrus lovincyrus marked this pull request as draft September 22, 2020 03:35
@clevinson
Copy link

Hey! I have this pending PR for cosmos-sdk to build multiple versions. How would I go about adding versions to the dropdown in this PR ?

@lovincyrus lovincyrus added the WIP label Sep 30, 2020
@lovincyrus
Copy link
Contributor Author

lovincyrus commented Sep 30, 2020

Hey! I have this pending PR for cosmos-sdk to build multiple versions. How would I go about adding versions to the dropdown in this PR ?

Hi @clevinson! This is very much still WIP. I plan to resolve this generating versioned docs before finalizing the version switcher implementation on the docs theme.

@lovincyrus lovincyrus mentioned this pull request Sep 30, 2020
@lovincyrus lovincyrus removed the WIP label Nov 12, 2020
@lovincyrus lovincyrus marked this pull request as ready for review November 12, 2020 21:46
@lovincyrus lovincyrus merged commit b586aba into develop Nov 12, 2020
@lovincyrus lovincyrus deleted the cyrus/versioning branch December 9, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants