Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to string using rune() again #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QuLogic
Copy link

@QuLogic QuLogic commented Jan 30, 2022

Not sure why this wasn't causing issues at the time of #101.

Also, I think the bounds check isn't necessary in this case because the Int64Val would have already done it, but I'm not certain.

@cosmos72
Copy link
Owner

The fragment you propose to modify is supposed to perform untyped integer -> untyped string conversion.

It must return a string, not a rune

@QuLogic
Copy link
Author

QuLogic commented Jan 31, 2022

Oops, I meant to wrap that in string again, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants