Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actualize eng demos with 0.96 #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Actualize eng demos with 0.96 #75

wants to merge 3 commits into from

Conversation

Zhaars
Copy link
Contributor

@Zhaars Zhaars commented Sep 16, 2024

  • Switch image version to newly released 0.96.0 across all compose files;
  • Updated READMEs for demos that use python examples that were changed in corresponded PR;
  • Adjust demos to use custom volumes defined in the compose files;
  • Update demo with cockroach to use custom entypoint.sh that setup correct permissions for certificates;

Lagovas
Lagovas reviewed Sep 16, 2024
View reviewed changes
cockroachdb/docker-compose.cockroachdb.yml
image: cockroachdb/cockroach:v21.2.3
build:
context: .
dockerfile: cockroach.dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave comment here that we need custom docker file to explicitly set proper permissions to the key file due to docker doesn't mount it properly on all systems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lagovas Lagovas Lagovas approved these changes

@iamnotacake iamnotacake Awaiting requested review from iamnotacake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhaars @Lagovas