Save window position on move (#1719)

coteditor · Oct 15, 2024 · b0c6050 · b0c6050
1 parent eac2d84
commit b0c6050
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 5.0.4 (unreleased)
 --------------------------
 
+### Fixes
+
+- Fix an issue that the document window position was not saved in some cases.
+
 
 
 5.0.3 (682)

diff --git a/CotEditor/Sources/Document Window/DocumentWindowController.swift b/CotEditor/Sources/Document Window/DocumentWindowController.swift
@@ -205,10 +205,13 @@ final class DocumentWindowController: NSWindowController, NSWindowDelegate {
 
     func windowDidResize(_ notification: Notification) {
 
-        guard self.isWindowLoaded, let window = self.window else { return }
+        self.saveWindowFrame()
+    }
+
+
+    func windowDidMove(_ notification: Notification) {
 
-        // workaround issue that window frame is not saved automatically (2022-08 macOS 12.5, FB11082729)
-        window.saveFrame(usingName: self.windowAutosaveName)
+        self.saveWindowFrame()
     }
 
 
@@ -287,6 +290,17 @@ final class DocumentWindowController: NSWindowController, NSWindowDelegate {
     }
 
 
+    /// Saves the current window frame.
+    ///
+    /// Workaround the issue that window frame is not saved automatically.
+    private func saveWindowFrame() {
+
+        assert(self.isWindowLoaded)
+
+        self.window?.saveFrame(usingName: self.windowAutosaveName)
+    }
+
+
     /// Restores the window opacity.
     private func restoreWindowOpacity() {