CBG-3867 disallow creating a replication with an empty ID (#6844)

db/sg_replicate_cfg.go

@@ -807,7 +807,7 @@ func (m *sgReplicateManager) RefreshReplicationCfg(ctx context.Context) error {
 			if !exists {
 				replicator, initError := m.InitializeReplication(replicationCfg)
 				if initError != nil {
-					base.WarnfCtx(m.loggingCtx, "Error initializing replication %s: %v", initError)
+					base.WarnfCtx(m.loggingCtx, "Error initializing replication %s: %v", replicationID, initError)
 					continue
 				}
 				m.activeReplicators[replicationID] = replicator
@@ -1071,7 +1071,9 @@ func (m *sgReplicateManager) PutReplications(replications map[string]*Replicatio
 
 // PUT _replication/replicationID
 func (m *sgReplicateManager) UpsertReplication(ctx context.Context, replication *ReplicationUpsertConfig) (created bool, err error) {
-
+	if replication.ID == "" {
+		return false, base.HTTPErrorf(http.StatusBadRequest, "Replication ID is required")
+	}
 	created = true
 	addReplicationCallback := func(cluster *SGRCluster) (cancel bool, err error) {
 		_, exists := cluster.Replications[replication.ID]

rest/replicatortest/replicator_test.go

@@ -8304,6 +8304,15 @@ func TestReplicatorWithCollectionsFailWithoutCollectionsEnabled(t *testing.T) {
 
 }
 
+func TestBanEmptyReplicationID(t *testing.T) {
+	rt := rest.NewRestTesterPersistentConfig(t)
+	defer rt.Close()
+
+	resp := rt.SendAdminRequest("POST", "/{{.db}}/_replication/", `{"remote": "fakeremote", "direction": "pull", "initial_state": "stopped"}`)
+	rest.RequireStatus(t, resp, http.StatusBadRequest)
+	require.Contains(t, string(resp.Body.Bytes()), "Replication ID is required")
+}
+
 func requireBodyEqual(t *testing.T, expected string, doc *db.Document) {
 	var expectedBody db.Body
 	require.NoError(t, base.JSONUnmarshal([]byte(expected), &expectedBody))