Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default for MULTI_NODE to avoid unbound variable error #6216

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Set default for MULTI_NODE to avoid unbound variable error #6216

merged 1 commit into from
Apr 27, 2023

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Apr 27, 2023

If the script was invoked without an explicit MULTI_NODE variable or -m these lines would error. Caused by change in #6215

https://jenkins.sgwdev.com/job/MasterIntegration/456/

./jenkins-integration-build.sh: line 123: MULTI_NODE: unbound variable

./integration-test/start_server.sh: line 58: MULTI_NODE: unbound variable

Integration Tests

  • n/a (this job always sets var even if false)

@bbrks bbrks requested a review from gregns1 April 27, 2023 07:28
@bbrks bbrks enabled auto-merge (squash) April 27, 2023 09:26
@bbrks bbrks merged commit 03e32ab into master Apr 27, 2023
@bbrks bbrks deleted the fix_unbound_variable branch April 27, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregns1 gregns1 gregns1 approved these changes

Assignees

@gregns1 gregns1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbrks @gregns1