Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3719: convert in memory format of HLV to match XDCR/CBL format #6655

Merged
merged 6 commits into from
Feb 1, 2024
Merged

CBG-3719: convert in memory format of HLV to match XDCR/CBL format #6655

merged 6 commits into from
Feb 1, 2024

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Jan 26, 2024 •
edited
Loading

CBG-3719

  • Changed the in memory structs to have string representation of version instead of uint64
  • Changes to tests to correctly asert on the new version values
  • Removal of json marshal and unmarshal function in Hybridlogicalvector.go as they're no longer needed
  • Added interface to hybridlogicalvector.go for ease of adding methods to act upon both HybridLogicalVector and DecodedHybridLogicalVector

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

  • Link upstream PRs
  • Update Go module dependencies when merged

Integration Tests

@gregns1 gregns1 assigned gregns1 and unassigned gregns1 Jan 26, 2024
bbrks
bbrks requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this looks good, just a couple of inline comments

db/hybrid_logical_vector.go Outdated Show resolved Hide resolved
db/hybrid_logical_vector.go Outdated Show resolved Hide resolved
db/hybrid_logical_vector.go Outdated Show resolved Hide resolved
db/hybrid_logical_vector.go Outdated Show resolved Hide resolved
bbrks
bbrks approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gregns1 gregns1 merged commit eedbd4a into beryllium Feb 1, 2024
17 checks passed
@gregns1 gregns1 deleted the CBG-3719 branch February 1, 2024 14:53
bbrks pushed a commit that referenced this pull request Apr 9, 2024
@gregns1 @bbrks
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
4527529 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
bbrks pushed a commit that referenced this pull request Apr 16, 2024
@gregns1 @bbrks
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
e9a4a0f 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
bbrks pushed a commit that referenced this pull request Apr 16, 2024
@gregns1 @bbrks
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
cd14556 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request May 7, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
a054f0c 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request May 10, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
ceafa08 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request May 14, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
858f2c9 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
torcolvin pushed a commit that referenced this pull request May 21, 2024
@gregns1 @torcolvin
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
26527fd 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request May 27, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
1340435 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request Aug 11, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
fe97102 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request Aug 11, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
0943429 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request Aug 13, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
e6ba899 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
adamcfraser pushed a commit that referenced this pull request Nov 29, 2024
@gregns1 @adamcfraser
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
4dce998 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
bbrks pushed a commit that referenced this pull request Dec 2, 2024
@gregns1 @bbrks
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
567a96e 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
bbrks pushed a commit that referenced this pull request Dec 5, 2024
@gregns1 @bbrks
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
2b08fb4 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
bbrks pushed a commit that referenced this pull request Dec 17, 2024
@gregns1 @bbrks
CBG-3719: convert in memory format of HLV to match XDCR/CBL format (#…
7148189 
…6655)

* CBG-3719: change in memory format of hlv to match XDCR/CBL format

* updates after rebase

* updates to fix missed type swap in channels package

* update to add encoded bucket UUID to db contect, this allows us to avoid overhead associated with encoding bucketUUID each time a HLV is updated

* updates after rebase

* updates based off review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees

@bbrks bbrks

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregns1 @bbrks @adamcfraser