Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manifest/3.2.xml back to product-config.json as a disabled entry. #6760

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

mhocouchbase
Copy link
Contributor

Describe your PR here...

currently, build-from-manifest-new keeps triggering manifest/3.2.xml and manifest/default.xml. Since both are 3.2.0, it causes https://github.com/couchbase/build-manifests/blob/master/sync_gateway/3.2.0/3.2.0.xml to be different on every scan. This results in a new build on every single scan. Having a disabled manifest/3.2.xml entry should stop "manifest/3.2.xml" from getting triggered.

-Ming

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

  • Link upstream PRs
  • Update Go module dependencies when merged

Integration Tests

This should stop jenkins from triggering 3.2.xml builds.

-Ming
@adamcfraser adamcfraser merged commit 68cfaa7 into couchbase:main Apr 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants