CBG-3883 Restore 3.1 handling for admin_channels, admin_roles #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitting default collection admin_channels, admin_roles on a PUT /db/_user should not remove those channels - callers must explicitly specify an empty array. Handling for named collections is unchanged - if scopes/collection is specified in collection_access, contents are treated as a replace. Added tests for interaction with JWT channel updates.
torcolvin
approved these changes
Apr 10, 2024
Comment on lines
+1310
to
+1311
| require.NoError(t, restTester.SetAdminParty(false)) | ||
| defer restTester.Close() |
There was a problem hiding this comment.
I would swap the order of these tests, but I think the default config for RestTester is GuestEnabled: false and this isn't needed at all.
There was a problem hiding this comment.
Going to leave this as-is for this PR as it follows pattern used by other OIDC tests, agree it could be updated across the board.
adamcfraser
changed the title
|
Failing CI tests pass locally, are unrelated to changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting default collection admin_channels, admin_roles on a PUT /db/_user should not remove those channels - callers must explicitly specify an empty array.
Handling for named collections is unchanged - if scopes/collection is specified in collection_access, contents are treated as a replace.
Added tests for interaction with JWT channel updates.
CBG-3883
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2379/