Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3856: Add missing permissions to GET /db/ endpoint #6847

Merged
merged 2 commits into from
Jun 3, 2024
Merged

CBG-3856: Add missing permissions to GET /db/ endpoint #6847

merged 2 commits into from
Jun 3, 2024

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented May 30, 2024 •
edited
Loading

CBG-3856

  • Added Architect role for get /db/ endpoint
  • Added test case to TestNewlyCreateSGWPermissions

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@gregns1 gregns1 changed the title CBG-3856 CBG-3856: Add missing permissions to GET /db/ endpoint May 30, 2024
@gregns1 gregns1 requested a review from bbrks June 3, 2024 07:52
@torcolvin torcolvin merged commit e8a5c63 into main Jun 3, 2024
34 checks passed
@torcolvin torcolvin deleted the CBG-3856 branch June 3, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcolvin torcolvin torcolvin approved these changes

@bbrks bbrks Awaiting requested review from bbrks

Assignees

@bbrks bbrks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregns1 @torcolvin @bbrks