CBG-3924: Add mocked config and API for audit logging #6874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
approved these changes
Jun 6, 2024
bbrks
force-pushed
the
feature/CBG-3822-audit-logging
branch
from
8403859 to
cd58f85
Compare
bbrks
changed the title
|
@JRascagneres should I wait until you've tried this toy build before I merge? |
|
@bbrks Up to you, might be a 'bit' away yet before I can test out all the endpoints. |
|
Can you at least review then to make sure the config and endpoints are as you'd expect? |
torcolvin
approved these changes
Jun 12, 2024
| type: boolean | ||
| default: false | ||
| enabled_events: | ||
| description: List of enabled audit events |
There was a problem hiding this comment.
Should this say that certain events will be enabled by default and have to be explicitly disabled?
There was a problem hiding this comment.
Had discussions with PM earlier this week. The plan is to have this represent the full set of enabled events. It contains the set of default events, and you can disable by removing from this list.
|
|
||
| Required Sync Gateway RBAC roles: | ||
|
|
||
| * TODO |
There was a problem hiding this comment.
Do we have a ticket to decide RBAC roles?
JRascagneres
approved these changes
Jun 13, 2024
bbrks
added a commit
that referenced
this pull request
Jun 14, 2024
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
bbrks
added a commit
that referenced
this pull request
Jun 20, 2024
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
bbrks
added a commit
that referenced
this pull request
Jun 20, 2024
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
bbrks
added a commit
that referenced
this pull request
Jul 2, 2024
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
bbrks
added a commit
that referenced
this pull request
Jul 2, 2024
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
1 task
bbrks
added a commit
that referenced
this pull request
Jul 8, 2024
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
bbrks
added a commit
that referenced
this pull request
Jul 8, 2024
* Add config fields for audit logging * Support all flag types and pointers in fillConfigWithFlags * tweak comment * wip * rebase fix for rotation_interval * Move uint map key to string for JSON * Add API specs * make GET API actually return the data... * Add placeholder audit log config for runtime server config * Add db/global audit log API changes * unindent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-3924
Unblocks Capella work since they can set the new config and reference new API endpoints.
SGAuditEventsfor visibility from handler.Toy build
https://mobile.jenkins.couchbase.com/view/Sync_Gateway/job/sgw-toy-build/258/
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/000/