Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3941 use infinite waiting for database init manager #6889

Merged
merged 9 commits into from
Jun 18, 2024
Merged

CBG-3941 use infinite waiting for database init manager #6889

merged 9 commits into from
Jun 18, 2024

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Jun 11, 2024 •
edited
Loading

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin
CBG-3941 use infinite waiting for database init manager
67a614b 
- create a LeakyClusterOnlyN1QLStore to allow better testing of init
  manager.
- wait for 15 minutes for index creation except via database init
  manager.
- remove unnecessary waiting for index if BUILD INDEX fails with a
  retryable error, since we already wait later for the index.
@torcolvin torcolvin requested a review from adamcfraser June 11, 2024 21:10
@torcolvin torcolvin assigned torcolvin and unassigned adamcfraser Jun 11, 2024
@torcolvin torcolvin assigned adamcfraser and unassigned torcolvin Jun 12, 2024
adamcfraser
adamcfraser requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor logging change suggested, and a question about the timer addition to RetryLoop.

base/collection_n1ql_common.go Outdated Show resolved Hide resolved
base/util.go Outdated Show resolved Hide resolved
@adamcfraser adamcfraser assigned torcolvin and unassigned adamcfraser Jun 13, 2024
torcolvin and others added 2 commits June 14, 2024 14:15
@torcolvin torcolvin requested a review from adamcfraser June 14, 2024 18:18
@torcolvin torcolvin removed their assignment Jun 14, 2024
@torcolvin torcolvin assigned torcolvin and adamcfraser and unassigned torcolvin Jun 17, 2024
@adamcfraser adamcfraser merged commit 630014e into main Jun 18, 2024
34 checks passed
@adamcfraser adamcfraser deleted the CBG-3941 branch June 18, 2024 17:03
gregns1 pushed a commit that referenced this pull request Jul 3, 2024
@torcolvin @adamcfraser @gregns1
CBG-3941 use infinite waiting for database init manager (#6889)
1d2c1b0 
* CBG-3941 use infinite waiting for database init manager

- create a LeakyClusterOnlyN1QLStore to allow better testing of init
  manager.
- wait for 15 minutes for index creation except via database init
  manager.
- remove unnecessary waiting for index if BUILD INDEX fails with a
  retryable error, since we already wait later for the index.

* wipe out testing changes

* Add RetryLoop test

* remove more unnecessary test changes

* Fix retry condition

* Update base/collection_n1ql_common.go

Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>

* Remove possibly expensive time calculation

* Change signature for leaky datastore

---------

Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torcolvin @adamcfraser