Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3783 do not print output of lsb_release #6900

Merged
merged 1 commit into from
Jun 20, 2024
Merged

CBG-3783 do not print output of lsb_release #6900

merged 1 commit into from
Jun 20, 2024

Conversation

torcolvin
Copy link
Collaborator

When running service/sync_gateway_service_install.sh script with --service-cmd, the output of the command is used. This is used to print value here:

${SERVICE_CMD}

When running script with --service-cmd, the output of scripts is used.
@bbrks
Copy link
Member

bbrks commented Jun 18, 2024

I'm not sure how the PR description relates to the changed lines?

Is this change to support shells that don't have a command builtin? Which shells?

@torcolvin
Copy link
Collaborator Author

I'm not sure how the PR description relates to the changed lines?

Is this change to support shells that don't have a command builtin? Which shells?

Running command -v lsb_release will output /usr/bin/lsb_release if the command is found. Since the output of service/sync_gateway_service_install.sh --service-cmd is supposed to just be systemctl start sync_gateway but if lsb_release exists on the system it is:

/usr/bin/lsb_release
systemctl start sync_gateway

The output of this command is used in the text that is printed when the package is installed.

@torcolvin torcolvin changed the title CBG-3783 do not output lsb_release CBG-3783 do not print output of lsb_release Jun 20, 2024
@torcolvin torcolvin merged commit b64d925 into main Jun 20, 2024
34 checks passed
@torcolvin torcolvin deleted the CBG-3783 branch June 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants