Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-4070: fix panic in CheckpointHash function #6971

Merged
merged 1 commit into from
Jul 17, 2024
Merged

CBG-4070: fix panic in CheckpointHash function #6971

merged 1 commit into from
Jul 17, 2024

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Jul 17, 2024 •
edited
Loading

CBG-4070

  • Added check for database context being nil or the bucket being nil
  • In my repro unit test, the bucket was the one that was nil thus causing the panic

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@gregns1 gregns1 requested a review from adamcfraser July 17, 2024 13:24
@adamcfraser adamcfraser merged commit a7f235e into main Jul 17, 2024
34 checks passed
@adamcfraser adamcfraser deleted the CBG-4070 branch July 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregns1 @adamcfraser