CBG-4058: Globally configurable audit events #7000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bal for enabled events in startup config
…ve now obsolete "non-filterable" db event.
Redocly previews |
adamcfraser
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4058
Makes a small subset of events globally configurable in the startup config, because they're not associated with any one database where we can hang the configuration from.
These events are not allowed to be defined on the database's
enabled_eventsconfiguration, and likewise, database-scoped events are not allowed to be defined in the startup config. This avoids inherietance/override complications, and there's no (current) case that a single event is always applicable to both (and filterable).It's possible this could change in the future (e.g. the log streaming allows database console log level/key settings to override the global one if set, maybe that approach could apply here too in future?)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2605/