Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1.10 backport] CBG-4127 use a non cancellable context for OIDC metadata #7061

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Aug 13, 2024

Backports 5db7dbe

This was not a clean cherry-pick, I split the difference on NewNonCancelCtxForDatabase to pull some of the dbname from the context but otherwise use nil db console logging config in auth package since it not on the LoggingContext in 3.1 branch.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

auth/oidc.go Outdated Show resolved Hide resolved
base/util.go Outdated Show resolved Hide resolved
@bbrks bbrks assigned torcolvin and unassigned bbrks Aug 13, 2024
@torcolvin torcolvin assigned bbrks and unassigned torcolvin Aug 13, 2024
@torcolvin torcolvin merged commit 5ee53c6 into release/3.1.10 Aug 13, 2024
24 checks passed
@torcolvin torcolvin deleted the CBG-4127 branch August 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants