Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3993: use md5 hash for sourceID in HLV #7073

Merged
merged 2 commits into from
Aug 16, 2024
Merged

CBG-3993: use md5 hash for sourceID in HLV #7073

merged 2 commits into from
Aug 16, 2024

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Aug 14, 2024 •
edited
Loading

CBG-3993

  • Copied the implementation of the UUIDstoDocumentSource in xdcr code base for the md5 hash then base64 encoding.
  • Assigned this calculation to the db context representation of the sourceID (updated the naming to reflect this).

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@gregns1 gregns1 requested a review from adamcfraser August 14, 2024 17:18
adamcfraser
adamcfraser reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you include in a comment a link to the corresponding XDCR code, so that it's clear what we need to keep in sync?

@adamcfraser adamcfraser assigned gregns1 and unassigned adamcfraser Aug 15, 2024
@gregns1 gregns1 assigned adamcfraser and unassigned gregns1 Aug 16, 2024
@adamcfraser adamcfraser merged commit 635e37d into release/anemone Aug 16, 2024
36 checks passed
@adamcfraser adamcfraser deleted the CBG-3993 branch August 16, 2024 19:56
adamcfraser pushed a commit that referenced this pull request Nov 29, 2024
@gregns1 @adamcfraser
CBG-3993: use md5 hash for sourceID in HLV (#7073)
20a687e 
* CBG-3993: use md5 hash for sourceID in HLV

* add comment on xdcr implementation
bbrks pushed a commit that referenced this pull request Dec 2, 2024
@gregns1 @bbrks
CBG-3993: use md5 hash for sourceID in HLV (#7073)
17bfa3c 
* CBG-3993: use md5 hash for sourceID in HLV

* add comment on xdcr implementation
bbrks pushed a commit that referenced this pull request Dec 5, 2024
@gregns1 @bbrks
CBG-3993: use md5 hash for sourceID in HLV (#7073)
9b65f93 
* CBG-3993: use md5 hash for sourceID in HLV

* add comment on xdcr implementation
bbrks pushed a commit that referenced this pull request Dec 17, 2024
@gregns1 @bbrks
CBG-3993: use md5 hash for sourceID in HLV (#7073)
f1eb0a0 
* CBG-3993: use md5 hash for sourceID in HLV

* add comment on xdcr implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregns1 @adamcfraser