Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3917: pass revNo from cbgt into feed event #7076

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Aug 14, 2024

CBG-3917

  • Passes rev no from cbgt into feed event
  • No test, can't find a nice way to assert on this like Tor did in his PR on the dcp client given this is managed by cbgt. I ran import unit test and stuck break point on the feed event and visually verified that the revNo is populated.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

Copy link
Collaborator

@torcolvin torcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run go.mod tidy?

I'd be OK upgrading cbgt on main too so these aren't out of sync, but I don't have a strong preference on that.

@gregns1 gregns1 assigned torcolvin and unassigned gregns1 Aug 16, 2024
@torcolvin torcolvin merged commit 0cd341a into release/anemone Aug 16, 2024
36 checks passed
@torcolvin torcolvin deleted the CBG-3917 branch August 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants