CBG-4221 [3.1.11 backport] Don't increment high sequence cached for unused sequences on pendingLogs #7106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to read side Reduces complexity and avoids loop bug when duplicates are present when running _addPendingLogs. When popping an unused sequence range from pendingLogs, checks for overlap with the next entry in pending. When found, truncates range at next pending entry. Adds check in addPendingLogs for the case where the pending includes sequences earlier than nextSequence. Info logging emitted for any unexpected duplication.
…nused sequences on pendingLogs If unused sequences ranges are pushed to pendingLogs, they shouldn't increment the channel cache's highSequenceCached until they are processed.
torcolvin
previously approved these changes
Sep 4, 2024
torcolvin
approved these changes
Sep 4, 2024
bbrks
added a commit
that referenced
this pull request
Nov 11, 2024
1 task
bbrks
added a commit
that referenced
this pull request
Nov 11, 2024
* Revert "CBG-4218 [3.1.11 backport] Move duplicate checks for pending sequences to read side (#7105)" This reverts commit b6127c1. * Revert "CBG-4221 [3.1.11 backport] Don't increment high sequence cached for unused sequences on pendingLogs (#7106)" This reverts commit 5ba7cd0. * Revert "CBG-4035: [3.1.9 backport] Skipped Sequence Optimisations (#6925)" This reverts commit ea40269. * Re-add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4221
If unused sequences ranges are pushed to pendingLogs, they shouldn't increment the channel cache's highSequenceCached until they are processed.
Backports CBG-4216