CBG-4253 create interfaces for integration testing #7112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
force-pushed
the
vv-integration-test
branch
4 times, most recently
from
aa68be6 to
7c82870
Compare
torcolvin
changed the title
torcolvin
force-pushed
the
vv-integration-test
branch
from
7c82870 to
c23d887
Compare
adamcfraser
requested changes
Sep 25, 2024
topologytest/topologies.go
Outdated
| peers: map[string]PeerOptions{ | ||
| "cbs1": {Type: PeerTypeCouchbaseServer, BucketID: PeerBucketID1}, | ||
| "sg1": {Type: PeerTypeSyncGateway, BucketID: PeerBucketID1}, | ||
| "cbl1": {Type: PeerTypeCouchbaseLiteMock, BucketID: PeerBucketID1}, |
There was a problem hiding this comment.
Can/should BucketID be omitted for CBL peers?
topologytest/topologies.go
Outdated
| peers: map[string]PeerOptions{ | ||
| "cbs1": {Type: PeerTypeCouchbaseServer, BucketID: PeerBucketID1}, | ||
| "sg1": {Type: PeerTypeSyncGateway, BucketID: PeerBucketID1}, | ||
| "cbl1": {Type: PeerTypeCouchbaseLiteMock, BucketID: PeerBucketID1}, |
There was a problem hiding this comment.
I expected this to be PeerTypeCouchbaseLite (and CouchbaseLiteMock would be one possible implementation of that peer).
topologytest/sync_gateway_peer.go
Outdated
| }) | ||
| config := rt.NewDbConfig() | ||
| config.AutoImport = base.BoolPtr(true) | ||
| rest.RequireStatus(t, rt.CreateDatabase("db", config), http.StatusCreated) |
There was a problem hiding this comment.
Should database name be name instead of "db", or is db required?
- move code to _test.go - force removal of BucketID for couchbase lite peers - remove uneeded SyncGatewayPeerID, now defined at replication time - use a better name to define a database (since peer ids are unique, but test names are too long) - define CouchbaseLitePeerType but the only implementation is a mock peer
adamcfraser
approved these changes
Sep 26, 2024
adamcfraser
pushed a commit
that referenced
this pull request
Nov 29, 2024
* CBG-4253 create interfaces for integration testing * fixups: - move code to _test.go - force removal of BucketID for couchbase lite peers - remove uneeded SyncGatewayPeerID, now defined at replication time - use a better name to define a database (since peer ids are unique, but test names are too long) - define CouchbaseLitePeerType but the only implementation is a mock peer
bbrks
pushed a commit
that referenced
this pull request
Dec 2, 2024
* CBG-4253 create interfaces for integration testing * fixups: - move code to _test.go - force removal of BucketID for couchbase lite peers - remove uneeded SyncGatewayPeerID, now defined at replication time - use a better name to define a database (since peer ids are unique, but test names are too long) - define CouchbaseLitePeerType but the only implementation is a mock peer
bbrks
pushed a commit
that referenced
this pull request
Dec 5, 2024
* CBG-4253 create interfaces for integration testing * fixups: - move code to _test.go - force removal of BucketID for couchbase lite peers - remove uneeded SyncGatewayPeerID, now defined at replication time - use a better name to define a database (since peer ids are unique, but test names are too long) - define CouchbaseLitePeerType but the only implementation is a mock peer
bbrks
pushed a commit
that referenced
this pull request
Dec 17, 2024
* CBG-4253 create interfaces for integration testing * fixups: - move code to _test.go - force removal of BucketID for couchbase lite peers - remove uneeded SyncGatewayPeerID, now defined at replication time - use a better name to define a database (since peer ids are unique, but test names are too long) - define CouchbaseLitePeerType but the only implementation is a mock peer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are intended to support https://docs.google.com/document/d/1oiPwTNKkdBkWbACvwEBsc3EbVD-PCTO1s6WCNvtwY7k work for version vectors, but are general enough to support any type of testing that requires replication.
This package lives outside the rest package since it doesn't necessarily use a REST API at all (it can for 1.x replications) and this allows easy skipping of these tests. Even in a minimal form, they take 75 secs to run under Couchbase Server and 5 seconds for rosmar.
A few test bugs were fixed:
controller/createReplication. Creating two unidirectional replications would cause one to fail.blip_client_test.gocode public in therestpackage to facilitate moving to a separate package. Minor modifications were needed to allow callingNewBlipTesterClientOptsWithRToutside ofbtcRunner.Run, since the tests are not conceptually run under a blip tester, blip testing just happens to be included. The check forbtcRunner.Runis used to be able to run withCBMobileReplicationV4andCBMobileReplicationV3in a loop correctly. With these tests, havingCBMobileReplicationV3would probably be a separate flag for a couchbase peer. A single test can have multiple CouchbaseLitePeers unlike standard testing so creatingAllowCreationWithoutBlipTesterClientRunneris used only for these tests.Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2714/