CBG-4369 optionally return CV on rest API #7203
Conversation
rest/bulk_api.go
Outdated
| @@ -276,9 +285,10 @@ func (h *handler) handleDump() error { | |||
| func (h *handler) handleRepair() error { | |||
| // TODO: If repair is re-enabled, it may need to be modified to support xattrs and GSI | |||
| err := errors.New("_repair endpoint disabled") | |||
| if err != nil { | |||
| /*if err != nil { | |||
There was a problem hiding this comment.
This looks like a change in auditing behaviour (to not audit when a no-op call to repair is made). Does it make sense in this PR?
There was a problem hiding this comment.
golangci-lint ci didn't pass without this change, I am not immediately sure why because it's not changed code.
There was a problem hiding this comment.
Now it did pass with this removed, I fixed this issue on main but anemone hasn't been rebased recently.
| @@ -364,6 +374,7 @@ func (h *handler) handleBulkGet() error { | |||
|
|
|||
| includeAttachments := h.getBoolQuery("attachments") | |||
| showExp := h.getBoolQuery("show_exp") | |||
| showCV := h.getBoolQuery("show_cv") | |||
There was a problem hiding this comment.
We should be consistent with the query parameter used to include cv in the responses. I'm fine with cvs=true like you've got in the all docs case.
There was a problem hiding this comment.
I did show_cv somewhat arbitrarily becuase I thought it made it clearer that it is an output parameter, especially when rev or revs can be input parameters to some functions.
Also cvs reminds me of a US pharmacy or the legacy version control system. I am happy to switch to cvs though.
| @@ -30,6 +30,7 @@ func (h *handler) handleGetDoc() error { | |||
| revid := h.getQuery("rev") | |||
| openRevs := h.getQuery("open_revs") | |||
| showExp := h.getBoolQuery("show_exp") | |||
| showCV := h.getBoolQuery("show_cv") | |||
There was a problem hiding this comment.
As above, let's pick a single query param name and use it throughout.
| @@ -173,3 +176,70 @@ func TestGuestReadOnly(t *testing.T) { | |||
| RequireStatus(t, response, http.StatusForbidden) | |||
|
|
|||
| } | |||
|
|
|||
| func TestGetDocWithCV(t *testing.T) { | |||
There was a problem hiding this comment.
Do we have a test case for bulk_get? I may just have missed it.
There was a problem hiding this comment.
Added missing test.
CBG-4369 optionally return CV on rest API
Implements getting cv out of the requests used in https://github.com/couchbaselabs/couchbase-lite-tests/blob/main/client/src/cbltest/api/syncgateway.py
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2807/