Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-4383 handle no revpos in attachment block #7210

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

torcolvin
Copy link
Collaborator

@torcolvin torcolvin commented Nov 25, 2024

CBG-4383 handle no revpos in attachment block

I'm not sure whether to implicit treat no revpos as 0 is OK or if I should avoid this entirely. TestForEachStubAttachment has code that relies on checking revpos.

I'm also not sure if we should output revpos in the output of GET /ks/doc but probably for pre 3.x compatibility.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@torcolvin torcolvin merged commit 586534e into release/anemone Nov 26, 2024
36 checks passed
@torcolvin torcolvin deleted the CBG-4383 branch November 26, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants